unify Densify trait (adds support for Geodesic, Rhumb) #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
changed the title
26 tasks
michaelkirk
force-pushed
the
mkirk/unify-densify
branch
from
61329c8
to
0a75848
Compare
|
Pushed up some missing docs - sorry 🙇 |
Just like #1228, but for Densify rather than Length. This enables Geodesic, Haversine, Euclidean, and Rhumb Densification. This required implementing InterpolatePoint for Euclidean. Adjacent work: deprecated legacy DensifyHaversine linestring_segment is now implemented in terms of the new Densify NOTE: linestring_segment would be a good future candidate for a similar unification across all the metric spaces
michaelkirk
force-pushed
the
mkirk/unify-densify
branch
from
0a75848
to
44dd231
Compare
kylebarron
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Supersedes #1208
Part of #1181
Densify is now generic, and implemented for anything that implements
Distance<Point, Point>andInterpolate<Point>.Specifically that means we continue to support Euclidean and Haversine densification, and now additionally support Geodesic and Rhumb.