GeodesicBearing and HaversineBearing return result #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cojmeister
commented
Mar 13, 2024
cojmeister
changed the title
cojmeister
commented
Mar 13, 2024
| @@ -44,8 +44,8 @@ where | |||
| fn cross_track_distance(&self, line_point_a: &Point<T>, line_point_b: &Point<T>) -> T { | |||
| let mean_earth_radius = T::from(MEAN_EARTH_RADIUS).unwrap(); | |||
| let l_delta_13: T = line_point_a.haversine_distance(self) / mean_earth_radius; | |||
| let theta_13: T = line_point_a.haversine_bearing(*self).to_radians(); | |||
| let theta_12: T = line_point_a.haversine_bearing(*line_point_b).to_radians(); | |||
| let theta_13: T = line_point_a.haversine_bearing(*self).unwrap().to_radians(); | |||
There was a problem hiding this comment.
Would change the signature of this function so that it also returns Result
| @@ -102,14 +102,14 @@ where | |||
| } | |||
|
|
|||
| let pi = T::from(std::f64::consts::PI).unwrap(); | |||
| let crs_ad = p1.haversine_bearing(*from).to_radians(); | |||
| let crs_ab = p1.haversine_bearing(p2).to_radians(); | |||
| let crs_ad = p1.haversine_bearing(*from).unwrap().to_radians(); | |||
There was a problem hiding this comment.
Would change signature to return result
| @@ -92,7 +92,7 @@ mod test { | |||
| let pt2 = Point::new(-170.0, -30.0); | |||
|
|
|||
| for (start, end) in [(pt1, pt2), (pt2, pt1)] { | |||
| let bearing = start.haversine_bearing(end); | |||
| let bearing = start.haversine_bearing(end).unwrap(); | |||
There was a problem hiding this comment.
Would change signature to return result
michaelkirk
reviewed
May 8, 2024
| Ok(()) | ||
| } | ||
|
|
||
| fn check_y_in_limits(&self) -> Result<(), String> { |
There was a problem hiding this comment.
Points can be projected - they might not be lat/lon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.I'm stuck in the comparison, I'm trying to implement the trait but I'm having issues. Any help would be appreciated.