Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gdal-src to 3.10.0 #574

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Oct 18, 2024

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

@lnicola lnicola changed the title Gdal src 3 10 Bump gdal-src to 3.10.0beta1 Oct 18, 2024
@lnicola
Copy link
Member Author

lnicola commented Oct 18, 2024

@weiznich quick question, how do you think we should version gdal-src? Maybe 0.3.10? Because I think GDAL sometimes has breaking changes in minor bumps.

@ChristianBeilschmidt
Copy link
Contributor

What is the idea behind using beta versions for gdal-src? Wouldn't it be better to use the latest stable one?

@lnicola
Copy link
Member Author

lnicola commented Oct 20, 2024

I'll upgrade this to 3.10 when it comes out. I just wanted to be ready for the release and spot any potential issues.

@weiznich
Copy link
Contributor

quick question, how do you think we should version gdal-src? Maybe 0.3.10? Because I think GDAL sometimes has breaking changes in minor bumps.

Crates like curl-sys and openssl-src use the build metadata part of the version for this.

That would mean we will end up with something like 0.1.1+gdal.3.10.0beta1 as version specifier.

@lnicola lnicola changed the title Bump gdal-src to 3.10.0beta1 Bump gdal-src to 3.10.0RC1 Oct 29, 2024
@lnicola lnicola changed the title Bump gdal-src to 3.10.0RC1 Bump gdal-src to 3.10.0RC2 Oct 31, 2024
@lnicola lnicola changed the title Bump gdal-src to 3.10.0RC2 Bump gdal-src to 3.10.0 Nov 7, 2024
@lnicola lnicola marked this pull request as ready for review November 7, 2024 06:27
@lnicola
Copy link
Member Author

lnicola commented Nov 7, 2024

Hmm, not sure what to do about the layout tests. I can generate FILE and VSIStatBuf as opaque types, but that just kicks the problem down the road with pub type FILE = [u64; 27usize];. And there's a bunch of functions that use those, like VSIFOpen.

@lnicola
Copy link
Member Author

lnicola commented Nov 7, 2024

Looking into the timespec error, it's a struct with two c_longs, that's (understandably) 16 bytes on Linux and 8 bytes on Windows. For now, we can either omit those structs or disable the layout tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants