-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows CI job #218
base: master
Are you sure you want to change the base?
Add Windows CI job #218
Conversation
Nice work @pka ; here's what I found about the failures:
|
Made a separate issue for the test failures: #219 |
Looks good @pka ; we could handle the errors in a separate PR. Should we merge this as is? |
I don't plan to fix the Windows tests bugs within this PR. When they are fixed, the |
Just curious, why the |
There is a impressive collection of build failures in https://github.com/pka/rust-gdal/actions. |
😕 |
Correction: The main failure
The |
In the meantime, the sdk from gisinternals has GDAL 3.4. So #231 has to be merged first. |
@pka what is the state of this PR? Is there something missing? |
It was ready for merge in January 22, but didn't test it again in the meantime. I'll do a rebase and we'll see if the build is still working. |
great! if all tests are green i will merge it. |
More failing tests on Windows in the meantime (see #219), but build is working. |
Incompatible tests are now disabled and CI doesn't ignore failing tests anymore. |
CHANGES.md
if knowledge of this change could be valuable to users.Test failures are ignored for now, because we have a few failures which are tracked in #219.