-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SensorThings API EDR Provider #1928
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doublebyte1
reviewed
Feb 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice @webb-ben : Thank you for this! 👍🏽
Maybe you could consider adding an example here? https://github.com/geopython/pygeoapi-examples
tomkralidis
requested changes
Feb 15, 2025
Formate STA EDR provider such that it does not require #noqa to pass CI
tomkralidis
approved these changes
Feb 15, 2025
doublebyte1
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
OGC API - Environmental Data Retrieval
OGC API - Environmental Data Retrieval
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces the SensorThings API EDR provider to pygeoapi core ported from https://github.com/cgs-earth/pygeoapi-plugins. The EDR provider is an implementation of the feature provider on the ObservedProperty entity. Using deep selection filters we are able to construct the necessary .
In the documentation I am not entirely sure how to relate query types and query arguments - each EDR Query Type has its own set of query arguments.
Related Issue / discussion
Additional information
L408-409 in
pygeoapi/provider/sensorthings_edr.py
note a TODO to recursively expand observations. This can be really expensive if query params aren't filtering the size of the response. Until EDR with limit as a query param is ready to be implemented, the default number returned by the SensorThings server is more than enough. Note that certain queries can be pretty taxing on the SensorThings endpoint especially without proper indexes created.Some views of queries:



Cube/Area:
Locations:


Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)