Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write manual section on running timing benchmarks. #5868

Merged

Conversation

MFraters
Copy link
Member

In the world builder I have been using timing benchmarks for a while now, which have been useful. It might be useful to do something similar the future for aspect, but to start out, and as requested in #5804, I wrote a section in the manual on how to set them up.

This pull request adds a section to the manual, explaining how to do these timing benchmarks with cbdr.

@MFraters MFraters force-pushed the write_manual_entry_on_time_benchmarking branch from 9c23630 to eb774c4 Compare June 10, 2024 22:06
Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite nice already, just some comments. I should add a page on callgrind in the same section in a later PR.

@MFraters MFraters force-pushed the write_manual_entry_on_time_benchmarking branch from 0a2bf87 to b14b826 Compare June 11, 2024 19:41
@MFraters MFraters force-pushed the write_manual_entry_on_time_benchmarking branch from b14b826 to 80293d5 Compare June 11, 2024 19:42
@MFraters
Copy link
Member Author

Thanks for the review. Good point about callgrind, that would make a nice addition.

I have addressed your comments.

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment left.

@MFraters
Copy link
Member Author

@gassmoeller Thanks, I applied your commit

@tjhei
Copy link
Member

tjhei commented Jun 12, 2024

@gassmoeller You can take a look at and/or reference https://integrated-earth.github.io/2023/02/03/perf.html

@gassmoeller
Copy link
Member

@gassmoeller You can take a look at and/or reference https://integrated-earth.github.io/2023/02/03/perf.html

I think this is a comment for @MFraters

@gassmoeller gassmoeller merged commit bfa0e47 into geodynamics:main Jun 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants