-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write manual section on running timing benchmarks. #5868
Write manual section on running timing benchmarks. #5868
Conversation
9c23630
to
eb774c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite nice already, just some comments. I should add a page on callgrind
in the same section in a later PR.
0a2bf87
to
b14b826
Compare
Co-authored-by: Rene Gassmoeller <[email protected]>
b14b826
to
80293d5
Compare
Thanks for the review. Good point about callgrind, that would make a nice addition. I have addressed your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment left.
Co-authored-by: Rene Gassmoeller <[email protected]>
@gassmoeller Thanks, I applied your commit |
@gassmoeller You can take a look at and/or reference https://integrated-earth.github.io/2023/02/03/perf.html |
I think this is a comment for @MFraters |
In the world builder I have been using timing benchmarks for a while now, which have been useful. It might be useful to do something similar the future for aspect, but to start out, and as requested in #5804, I wrote a section in the manual on how to set them up.
This pull request adds a section to the manual, explaining how to do these timing benchmarks with cbdr.