Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try xarray #192

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Try xarray #192

merged 1 commit into from
Oct 8, 2023

Conversation

Robinlovelace
Copy link
Contributor

No description provided.

@Robinlovelace Robinlovelace linked an issue Oct 8, 2023 that may be closed by this pull request
2 tasks
@Robinlovelace Robinlovelace mentioned this pull request Oct 8, 2023
2 tasks
@michaeldorman
Copy link
Collaborator

Hi @Robinlovelace , thanks for this, it's a good option, however I suggest to use osgeo.gdal for this, such as here:
https://stackoverflow.com/questions/47653271/calculating-aspect-slope-in-python3-x-matlab-gradientm-function
which is already used in the contour example in chapter 5. Will be happy to hear what you think

@michaeldorman
Copy link
Collaborator

Another option could be to go back to the command line gdal_contour for the contour example, and accordingly to use command line gdaldem for the slope and aspect examples. These don't have to be evaluated I guess, we could say that it is for the reader to explore in case they need these and other operations that are easier done using GDAL than in Python.

@Robinlovelace
Copy link
Contributor Author

Hi @Robinlovelace , thanks for this, it's a good option, however I suggest to use osgeo.gdal for this, such as here: https://stackoverflow.com/questions/47653271/calculating-aspect-slope-in-python3-x-matlab-gradientm-function which is already used in the contour example in chapter 5. Will be happy to hear what you think

Sounds like a good plan 👍

@Robinlovelace
Copy link
Contributor Author

gdal_contour and other GDAL options also sound good to me, whichever works best for you. I think there are some bits of this PR that may be worth keeping, notably the de-emphasizing of richdem so feel free to checkout this PR and make additional changes.

Alternatively, I can update this PR so it makes no change to the Python code by lays the foundations for a future change. Would that be useful?

@michaeldorman michaeldorman merged commit ec1c254 into main Oct 8, 2023
@michaeldorman
Copy link
Collaborator

gdal_contour and other GDAL options also sound good to me, whichever works best for you. I think there are some bits of this PR that may be worth keeping, notably the de-emphasizing of richdem so feel free to checkout this PR and make additional changes.

Alternatively, I can update this PR so it makes no change to the Python code by lays the foundations for a future change. Would that be useful?

Sure, thanks! I've merged and then will edit the code parts

github-actions bot pushed a commit that referenced this pull request Oct 8, 2023
@Robinlovelace Robinlovelace deleted the 191-reminder-about-richdem-1 branch October 9, 2023 07:23
@Robinlovelace
Copy link
Contributor Author

Sounds like a plan and didn't think of that third option which in hindsight was best: merge + edit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reminder about 'richdem'
2 participants