added 2 year leaf expiration

[itsouvalas]

Given the fact that each certificate rotation happens slightly earlier than a full year, subsequent rotations may collide with other critical scheduled jobs or otherwise intensive calendar days (vacation, fiscal year ending, promotions etc).
The proposed changes allow for each leaf certificate to last for two years which allows the operator to schedule the leaf certificate rotation on a yearly basis without having to make any changes based on the impending certificate expiry.

[dennisjbell]

Lets make this feature 'custom-ssl-cert-expiry' and add a params.ssl-cert-ttl-days that can be spruce grabbed into the file. Or make it not a feature at all, but have the params.ssl-cert-ttl-days default to 1 year using (( grab param.ssl-cert-ttl-days || "365" )) where we currently specify 730

[itsouvalas]

Indeed you are correct, and this was proposed right after my pr. Default to what is already expected and give the ability to the operator to edit accordingly. I was reviewing the majority of our kits to make this a standard approach hence the lack of updates here. On it!