Always get requirements from master while installing from a fork but not from a different repository #9039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fork but not from a different repository
micheles
approved these changes
Sep 26, 2023
micheles
reviewed
Sep 26, 2023
install.py
Outdated
| if repository != 'gem/oq-engine': | ||
| repository_owner, repository_name = repository.split('/') | ||
| # in forks of oq-engine, always read requirements from master | ||
| if (repository_owner != 'gem' and repository_name == 'oq-engine'): |
There was a problem hiding this comment.
The parenthesis are not needed
There was a problem hiding this comment.
Acc! I see a problem here!
I want the requirements to be read from OUR master, not from their master that could be outdated.
There was a problem hiding this comment.
According with this https://github.com/gem/oq-engine/blob/master/install.py#L393 I believe requirements are actually read from our master.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we would have a mismatch e.g. when running tests from another gem repository installing the engine with
python install.py user(in that case we need to get the requirements from the latest stable release instead)