-
-
Notifications
You must be signed in to change notification settings - Fork 645
Add debug mode and hide deprecation warnings by default #1563
base: master
Are you sure you want to change the base?
Conversation
I especially like the ability to tell users in the issue queue to run |
My main question is what does the debug .cfg file provide over the normal one? It seems like it would just be the first few messages at the top of the Ansible playbook output—but is there any more? Maybe it's just my late-night read of the code... |
I do like the idea of hiding the deprecation warnings. Since 2.2, it seems like Ansible will be popping deprecation warnings for some commonly-used features that don't have a backwards-compatible fix, so either we live with the warnings, I break compatibility with Ansible < latest, or we do this. Since Drupal VM is an end-user-oriented system, it shouldn't be showing these more playbook-developer-centric messages since the end user can't really do anything about it. |
No that's it but I wasn't aware of disabling depreciation notices any other way than with a config file. Is it possible somehow? |
Also as I'm fixing the bug where the |
I'll take a second look soon since I finally had some time to finish up the 4.7.0 release. |
@oxyc - This looks great! One last suggestion—can we add something in the docs about setting |
I'm closing PRs which have conflicts or are failing builds and are older than 6 months old, to tidy up the Drupal VM PR queue; please create a new PR against the latest master branch if you feel this is still an important fix or feature for Drupal VM. Thank you! |
(Note that I'm still for these changes, with the small addition of something about debugging with |
I'll reopen this and work on the docs (soon!) |
This defaults to a hashed string of the hostname, port and username. The hash mitigates a common problem users found with long hostames and the conventional %(directory)s/ansible-ssh-%%h-%%p-%%r format. In those cases, a "too long for Unix domain socket" ssh error would occur.
Examples: - DRUPALVM_DEBUG=1 vagrant provision (ansible-playbook -v) - DRUPALVM_DEBUG=v vagrant provision (ansible-playbook -v) - DRUPALVM_DEBUG=vvv vagrant provision (ansible-playbook -vvv)
Issue #1553. I'm assuming you're not going to bump the version requirements of all your roles to 2.4.0. If you are we could drop the conditional
ansible.cfg
config.ansible.cfg
was never loaded with Vagrant. It would need to reside next to theVagrantfile
to do so.control_path
no longer needs to be set inansible.cfg
(read 633810a)DRUPALVM_DEBUG
environment variable to easily debug ansible tasks (see examples in 93abae9)