enh: Allow default vhost path override #245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark issues as stale. |
jfoliveira
suggested changes
Apr 9, 2024
vars/FreeBSD.yml
Outdated
| @@ -5,5 +5,5 @@ nginx_conf_file_path: /usr/local/etc/nginx/nginx.conf | |||
| nginx_mime_file_path: /usr/local/etc/nginx/mime.types | |||
| nginx_pidfile: /var/run/nginx.pid | |||
| nginx_vhost_path: /usr/local/etc/nginx/sites-enabled | |||
| nginx_default_vhost_path: /usr/local/etc/nginx/sites-enabled/default | |||
| nginx_default_vhost_path: "{{ nginx_override_default_vhost_path | default('/usr/local/etc/nginx/sites-enabled/default') }}" | |||
There was a problem hiding this comment.
GitHub Actions
/ Lint
8:121 [line-length] line too long (123 > 120 characters)
Suggested change
| nginx_default_vhost_path: "{{ nginx_override_default_vhost_path | default('/usr/local/etc/nginx/sites-enabled/default') }}" | |
| nginx_default_vhost_path: > | |
| {{ nginx_override_default_vhost_path | | |
| default('/usr/local/etc/nginx/sites-enabled/default') }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to use an alternative default vhost filename (to be able to remove it!).
Some distribution and/or package supplier changed the default vhost file over time.
For example in nginx 1.24 Debian package supplied by nginx.org, vhost default file supplied is now '/etc/nginx/conf.d/default.conf' instead of '/etc/nginx/sites-enabled/default' previously.
just set variable nginx_override_default_vhost_path accordingly.
if nginx_override_default_vhost_path is not set nothing changes.