Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use ansible_facts rather than variables #423

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jackhodgkiss
Copy link

This PR addresses the issue raised in #422 by replacing ansible_ with ansible_facts. counterparts.

Has been tested numerous times within Ubuntu 22.04.

@markgoddard
Copy link

LGTM

@geerlingguy
Copy link
Owner

Seems like there's a merge conflict—happy to merge once that's fixed up!

@jackhodgkiss
Copy link
Author

Merge conflict resolved.

@markgoddard
Copy link

How's this looking now @geerlingguy?

Copy link

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions bot added the stale label Feb 26, 2024
@markgoddard
Copy link

@geerlingguy please could you merge this one? Thanks

Copy link

github-actions bot commented Jul 8, 2024

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions bot added the stale label Jul 8, 2024
@markgoddard
Copy link

:(

@github-actions github-actions bot removed the stale label Jul 15, 2024
@jamesmyatt
Copy link
Contributor

@geerlingguy , looks like this has been ready for a year. Any chance of merging it?

@geerlingguy
Copy link
Owner

@jamesmyatt - Only reason I haven't merged is I wanted to take some time and update this across all my roles at once, for consistency... still might do that, or go ahead and merge in some roles sooner, we'll see.

It doesn't really harm the roles to use the old way though.

@jamesmyatt
Copy link
Contributor

Makes sense. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants