Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update APT cache on first invocation #406

Closed
wants to merge 1 commit into from
Closed

Update APT cache on first invocation #406

wants to merge 1 commit into from

Conversation

abalage
Copy link

@abalage abalage commented Mar 7, 2023

Explicitly call package cache update only on first occurrence.

@abalage
Copy link
Author

abalage commented Mar 7, 2023

Fixes #407

@stale
Copy link

stale bot commented Jun 18, 2023

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Jun 18, 2023
@abalage
Copy link
Author

abalage commented Jun 19, 2023

Okay I got the things written in that blog, no problem with that.
However the fix is just a single line, without breaking anything but solving reported issues.
Imho it would be pity not incorporating that. :)

@stale
Copy link

stale bot commented Jun 19, 2023

This issue is no longer marked for closure.

@stale stale bot removed the stale label Jun 19, 2023
@geerlingguy
Copy link
Owner

This will break idempotence—for my roles, I always manage apt caches at the play level, not at the role level. Otherwise every role I have, I would need to add in update_cache and manage a lifetime for the cache, which I'd rather not do since everyone has a different approach. See: https://github.com/geerlingguy/ansible-role-docker/blob/master/molecule/default/converge.yml#L6-L9

@abalage
Copy link
Author

abalage commented Jun 22, 2023

Yes I went down that path too because of the change was not merged when I made the PR.
Thanks for the feedback though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants