Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch4 nodejs Fixes #413

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ch4 nodejs Fixes #413

wants to merge 2 commits into from

Conversation

MCDELTAT
Copy link

@MCDELTAT MCDELTAT commented Jul 9, 2021

Removed Remi Repo tasks from Playbook. The CentOS 7/8 Repo does not contain npm or any of the required RPMs see here. EPEL 7 contains an npm package (3.10.0) but EPEL 8 does not because nodejs 10 and 12 LTS is available in the built-in AppStream repos.

Added version to package.json to fix bug that existed in version 3.3.0-3.3.1 of community.general.npm module. It would fail if a version tag was not available. This was fixed in 3.3.2, but should be there since it's included in the simple npminit values. See commit here

Removed Remi Repo tasks from Playbook. Remi repo does not contain npm or any of the required RPMs. Added version to package.json to fix bug that existed in version 3.3.0-3.3.1 of community.general.npm module.
@MCDELTAT MCDELTAT marked this pull request as ready for review July 10, 2021 08:09
@geerlingguy
Copy link
Owner

Honestly I don't remember why I had the remi tasks in there...

@MCDELTAT
Copy link
Author

Hmm. I see the one that failed is getting the same error as I was getting, which is caused by not using 3.3.2+ of community.general.npm

I can't see what role you're applying to download that Galaxy package, but it likely needs updating there first.

Triggering CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants