Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageCollection.containsBandNames: add argument to indicate the property that contains the band names #425

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

fitoprincipe
Copy link
Member

@fitoprincipe fitoprincipe commented Jan 29, 2025

In some image collections the images contain all bands but some are completely masked out. In this case, using the band names is useless and mosaicking will not fail, but the user could still want to use valid bands and avoid the masked ones.

There are 2 changes:

  1. Use already computed system property system:band_names instead of computing it on the fly and storing in a property with random name.
  2. Allow the user to specify the name of the property that contains the band names.

@fitoprincipe fitoprincipe requested a review from 12rambau January 29, 2025 10:33
@12rambau
Copy link
Member

@fitoprincipe can you rebase your branch on current main I made a patch to avoid the service account issue generated from GEE latest update ?

@fitoprincipe
Copy link
Member Author

done

Copy link
Member

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart from the docstring wording the rest is perfect, thanks !

@12rambau 12rambau merged commit 14fdc79 into main Feb 5, 2025
11 checks passed
@12rambau 12rambau deleted the improve-filter-by-bands branch February 5, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants