Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Input Dialog refactor] Replace 5 function parameters with 2 #3826

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[Input Dialog refactor] Replace 5 function parameters with 2 #3826

wants to merge 3 commits into from

Commits on Apr 8, 2024

  1. [Input Dialog refactor] Replace 5 parameters with 1 

    `dialogs_show_input_full` had grown into a monster.
All that complexity can be removed if the caller creates the combo/entry
widget, as they can then connect signals themselves.
    @ntrel
    ntrel committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    3b0bf7e View commit details
    Browse the repository at this point in the history

  2. Add entry parameter for flexibility

    @ntrel
    ntrel committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    d3a8c86 View commit details
    Browse the repository at this point in the history

  3. Also wrap label for dialogs_show_input_numeric

    @ntrel
    ntrel committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    f10afe7 View commit details
    Browse the repository at this point in the history