Add "session-opening" signal emitted when session opening starts/stops #3707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When session opening starts, this signal is emitted with parameter TRUE, when it stops, with FALSE. This gives plugins information e.g. whether document opening happens as a result of user action or whether it's part of initial session opening.
|
Does this fix #3684? |
|
This might also be useful for ProjectOrganizer plugin. It could simplify the code introduced geany/geany-plugins#1290, if the project opening and file parsing happened after Geany opens all the files in session. |
I'm just afraid that the result would be "stuck on loaded document" instead of "stuck on nothing open" (which looks better) so we'd be back where we were with the idle function... |
|
Closing in favor of #3870. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When session opening starts, this signal is emitted with parameter TRUE, when it stops, with FALSE.
This gives plugins information e.g. whether document opening happens as a result of user action or whether it's part of initial session opening.
For the LSP plugin this is used to detect the finally displayed document for which the server is started, otherwise if "document-open" is used, it would start servers for all open document filetypes immediately on Geany start which is unnecessary and could slow start time.