Windows installer: Prefer Geany installation directory over user's HOME #1324
+14
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no explicit installation directory was specified and an existing, Geany installation was found, then use its installation directory. Closes geany#1321.
eht16
commented
Apr 14, 2024
| @@ -401,6 +398,12 @@ Function .onInit | |||
| StrCpy $INSTDIR "$GEANY_INSTDIR" | |||
| ${EndIf} | |||
|
|
|||
| ; if $INSTDIR has not been set yet above, set it to the profile directory for non-admin users | |||
| ${If} $INSTDIR == "" | |||
There was a problem hiding this comment.
The diff is a bit cluttered because of the variable rename (I don't know what was wrong with me naming it "Answer" :( ), the relevant part is here: we set $INSTDIR only to the user's profile directory if we didn't find a Geany installation before. Before the Geany installation was ignored if the installer was executed without administrative privileges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no explicit installation directory was specified and an existing, Geany installation was found, then use its installation directory.
Closes #1321.