Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gdsfactory requirement from ~=8.4.0 to >=8.4,<8.33 #69

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 20, 2025

Updates the requirements on gdsfactory to permit the latest version.

Release notes

Sourced from gdsfactory's releases.

v8.32.2

What's Changed

Bug Fixes

  • Fix grating coupler loss #3666

Maintenance

  • add warning for python3.10 #3673

Documentation

  • Fix grating coupler loss #3666

Full Changelog: gdsfactory/gdsfactory@v8.32.1...v8.32.2

Changelog

Sourced from gdsfactory's changelog.

8.32.2 - 2025-02-14

  • Fix grating coupler loss #3666
  • add warning for python3.10 #3673

8.32.1 - 2025-02-10

  • solid dither pattern does not exist #3650
  • fix type annotations #3649
  • Support via stack different xy offsets #3657
  • better instance validation errors #3652
  • fix type annotations #3649
  • Small improvements #3648

8.32.0 - 2025-02-04

  • making auto tapering reflexive #3647

8.31.4 - 2025-02-02

  • flatten_nitride_transition #3644

8.31.3 - 2025-02-01

  • Fix nitride transition #3643

8.31.2 - 2025-01-27

  • fix cutback_component #3638
  • Unclamp trimesh dependency #3637

8.31.1 - 2025-01-27

  • remove zero length waveguides from cutback_component #3635
  • Fix mypy issue #3629
  • cleanup_precommit #3636
  • [pre-commit.ci] pre-commit autoupdate #3634
  • add remove_old_layer_flag to over_under #3627
  • improve pack error message #3626

8.31.0 - 2025-01-22

  • add tests for containers #3620
  • Add more tests #3614
  • fix gf.boolean for arrays #3622
  • remove default 1,0 boolean layer #3624
  • Underscore intermediate functions #3623
  • add tests for containers #3620

... (truncated)

Commits
  • a310549 Bump to 8.32.2
  • 40723a0 Merge pull request #3673 from gdsfactory/drop_python310
  • f99d019 add warning for python3.10
  • bad1fbf Fix grating coupler loss (#3666)
  • ee7cf51 update changelog
  • e41f2c0 Bump to 8.32.1
  • 0a6777b Merge pull request #3657 from gdsfactory/support_via_stack_different_xy_offsets
  • 1e5f8c0 fix mypy
  • af4971e [pre-commit.ci] auto fixes from pre-commit.com hooks
  • 3909653 Merge branch 'main' of github.com:gdsfactory/gdsfactory
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by Sourcery

Update gdsfactory dependency to allow versions greater than or equal to 8.4 and less than 8.33.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Mar 20, 2025
Copy link

sourcery-ai bot commented Mar 20, 2025

Reviewer's Guide by Sourcery

This pull request updates the gdsfactory dependency in pyproject.toml to allow versions greater than or equal to 8.4 but less than 8.33. This ensures compatibility with the latest gdsfactory releases while avoiding potential breaking changes in future major/minor releases.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update the gdsfactory dependency version in pyproject.toml.
  • Changed the version specifier from ~=8.4.0 to >=8.4,<8.33.
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!
  • We don't review packaging changes - Let us know if you'd like us to change this.

Updates the requirements on [gdsfactory](https://github.com/gdsfactory/gdsfactory) to permit the latest version.
- [Release notes](https://github.com/gdsfactory/gdsfactory/releases)
- [Changelog](https://github.com/gdsfactory/gdsfactory/blob/main/CHANGELOG.md)
- [Commits](gdsfactory/gdsfactory@v8.4.0...v8.32.2)

---
updated-dependencies:
- dependency-name: gdsfactory
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/gdsfactory-gte-8.4-and-lt-8.33 branch from 3385a36 to 23378e3 Compare March 22, 2025 17:40
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 24, 2025

Superseded by #70.

@dependabot dependabot bot closed this Mar 24, 2025
@dependabot dependabot bot deleted the dependabot/pip/gdsfactory-gte-8.4-and-lt-8.33 branch March 24, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants