-
Notifications
You must be signed in to change notification settings - Fork 6
add more tests #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joamatab
wants to merge
2
commits into
main
Choose a base branch
from
better_changelog
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add more tests #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideAdds a new GFP-specific test job to the GitHub Actions workflow and introduces automated changelog generation using towncrier integrated with tbump. Flow diagram for tbump and towncrier changelog generationflowchart LR
Dev[Developer] --> Run_tbump[Run_tbump_for_new_version]
Run_tbump --> Tbump_before_commit[tbump_before_commit_hook]
Tbump_before_commit --> Towncrier_cmd[towncrier_build_with_new_version]
Towncrier_cmd --> Read_fragments[Read_entries_from_changelog_d]
Read_fragments --> Apply_template[Apply_changelog_template_jinja]
Apply_template --> Update_changelog[Update_CHANGELOG_md_after_start_string]
Update_changelog --> Git_commit[Commit_version_and_changelog_changes]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Consider scoping
GFP_API_KEYto only thetest_gfpjob instead of defining it at the workflow level if no other jobs require it, to reduce unnecessary secret exposure. - The Towncrier config uses
issue_formatandpackagevalues pointing togdsfactory/gf180mcuandgdsfactory; double-check these match this repository’s actual org/repo and package name to avoid broken links or incorrect metadata in the generated changelog.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider scoping `GFP_API_KEY` to only the `test_gfp` job instead of defining it at the workflow level if no other jobs require it, to reduce unnecessary secret exposure.
- The Towncrier config uses `issue_format` and `package` values pointing to `gdsfactory/gf180mcu` and `gdsfactory`; double-check these match this repository’s actual org/repo and package name to avoid broken links or incorrect metadata in the generated changelog.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Configure automated changelog generation and GFP tests in CI.
Build:
CI:
Documentation: