fix HTML title + logo as SVG #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I deleted the logo source files by mistake, but they were in the git history. Do these files help (created with Inkscape under Linux)? https://github.com/gdoor-org/gdoor-org.github.io/tree/main/assets/images/logo |
|
Thanks, yes, that was helpful. I added a highly optimized SVG here: https://github.com/gdoor-org/gdoor-org.github.io/tree/main/assets/images/logo Not sure what these files are there for: https://github.com/gdoor-org/gdoor-org.github.io/tree/main/_src/logo ? |
|
Hm, I forgot this folder 😅 |
|
I did some cleanup: gdoor-org/gdoor-org.github.io@7537c4d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the HTML title of the wifimanager portal by adding the logo as inline SVG in CSS.
Since I don't have the font installed that it used in https://github.com/gdoor-org/gdoor-org.github.io/blob/d408e10103a08ccb7faadb3d52b921d02b86e590/_src/logo/logo.svg it looks a bit different. @DaSchaef, could you convert all text to paths and export the SVG again, so the SVG renders nicely also when the font isn't locally installed? Then we could use the SVG instead of the JPG/PNG in all places (incl. the website).