A simple/model implementation of being able to obtain harvested metadata records unparsed, as Strings

[landreev]

• Closes Feature request: I'd like to be able to instruct my OAI client to return harvested metadata records unparsed, as Strings #284 (maybe?)

As the title says, this is a "model" implementation - primarily to illustrate what I want the final result to be on the application side.
I expect that it will likely need to be implemented differently before the PR can be merged. I'm happy to work on a cleaner/better implementation.

[pdurbin]

I didn't run this but it seems reasonable to me.

[poikilotherm]

We should talk about this some more. I think there is a cleaner way to do this, maybe using the existing CopyElement or adding a new RawElement.

See

xoai/xoai-common/src/main/java/io/gdcc/xoai/model/oaipmh/results/record/Metadata.java

Line 55 in 83f9c1b

public boolean needsProcessing() {

and its usages in the data provider code parts. It seems the use cases are quite similar.

Also, this PR does not yet contain any unit tests. It might be interesting to see some benchmark tests as well to compare different approaches.

[landreev]

Yes, sure, happy to talk about it this week.

I think there is a cleaner way to do this, maybe using the existing CopyElement or ...

The way I implemented it, using the existing EchoElement seemed like the easiest way to go about it at the moment. (What we did with CopyElement in the data provider was specifically in order to allow passing an InputStream to a metadata fragment cached in storage; and that seems like an overkill for what's needed here). But let me take another look.

Yes, I will add a test shortly.

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[landreev]

I really like the xoai-data-provider-tck subsystem. You suggested at some point that this approach could be used for testing OAI functionality in Dataverse and I am considering implementing something similar.
I am however getting one strange validation failure when running it locally:

### Checking GetRecord response
...
FAIL:    Expected setSpec was missing from the response. The GetRecord response for identifier IdFgUHOANT did not contain a set specification for test1

(everything else appears to be passing).
It is passing when the PR is tested here on github:

PASS:    Expected setSpec was returned in the response

I'm puzzled as to what's going on - ?

[landreev]

If you feel strongly about it, please let me know and I'll be happy to change the code to use CopyElement instead. Having taken another look at the classes, it doesn't seem like it's going to be much simpler/require fewer changes, but either way is ok with me.

[landreev]

Can we talk about this sometime soon?

[poikilotherm]

Let's do a VC call tomorrow! Ping me on Zulip, I don't have any appointments tomorrow. (I wasn't paying attention to this thread, halfway expecting you to ping me via DM again. Sorry!)