Gh-3215: Fix HasStep filtering #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create modern dataset test utils
simplify + tidy
p29876
commented
May 17, 2024
library/tinkerpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraph.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3216 +/- ##
=============================================
+ Coverage 66.89% 66.96% +0.07%
+ Complexity 2558 2556 -2
=============================================
Files 912 912
Lines 29303 29366 +63
Branches 3267 3273 +6
=============================================
+ Hits 19602 19665 +63
+ Misses 8256 8254 -2
- Partials 1445 1447 +2 ☔ View full report in Codecov by Sentry. |
tb06904
reviewed
May 20, 2024
...op/src/main/java/uk/gov/gchq/gaffer/tinkerpop/process/traversal/step/GafferPopGraphStep.java
Show resolved
Hide resolved
...op/src/main/java/uk/gov/gchq/gaffer/tinkerpop/process/traversal/step/GafferPopGraphStep.java
Outdated
Show resolved
Hide resolved
...op/src/main/java/uk/gov/gchq/gaffer/tinkerpop/process/traversal/step/GafferPopGraphStep.java
Outdated
Show resolved
Hide resolved
...op/src/test/java/uk/gov/gchq/gaffer/tinkerpop/process/traversal/step/GafferPopHasStepIT.java
Show resolved
Hide resolved
library/tinkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/util/GafferPopModernTestUtils.java
Show resolved
Hide resolved
library/tinkerpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraph.java
Outdated
Show resolved
Hide resolved
library/tinkerpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraph.java
Outdated
Show resolved
Hide resolved
actually fixes the GremlinTypeError issues as well
GCHQDeveloper314
changed the title
tb06904
approved these changes
May 30, 2024
cn337131
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue