Gh-3210: Fix GafferPopVertex.properties() output #3211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set a proper ID for GafferPopVertexProperties so that equals and hashCode work as expected simplify GafferPopVertex.properties() method add unit test to catch error
p29876
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3211 +/- ##
=============================================
- Coverage 66.85% 66.85% -0.01%
Complexity 2555 2555
=============================================
Files 912 912
Lines 29284 29276 -8
Branches 3268 3265 -3
=============================================
- Hits 19578 19572 -6
+ Misses 8259 8258 -1
+ Partials 1447 1446 -1 ☔ View full report in Codecov by Sentry. |
tb06904
previously approved these changes
May 15, 2024
library/tinkerpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopVertex.java
Outdated
Show resolved
Hide resolved
Co-authored-by: GCHQDeveloper314 <[email protected]>
tb06904
approved these changes
May 16, 2024
GCHQDeveloper314
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a proper ID for GafferPopVertexProperties so that equals and hashCode work as expected
simplify GafferPopVertex.properties() method
add unit test to catch error
Related issue