fix(ecdsa): feat deriveevp use of password hash with insufficient computational effort #2077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CyberChef/src/core/operations/DeriveEVPKey.mjs
Line 48 in c57556f
CyberChef/src/core/operations/DeriveEVPKey.mjs
Lines 72 to 75 in c57556f
fix address the DeriveEVP, the
CryptoJS.EvpKDF
function should be replaced with a modern and secure key derivation scheme likePBKDF2
. ThePBKDF2
algorithm is widely recommended and supported by libraries such ascrypto
orcrypto-js
. Specifically:CryptoJS.EvpKDF
function withCryptoJS.PBKDF2
.MD5
from the list of options and default to a strong hash function such asSHA256
.Changes will be made to the
run
method, and the hashing function options in the constructor will be updated to only include secure options.