Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI target OSes #1083

Merged
merged 4 commits into from
Oct 2, 2022
Merged

Update CI target OSes #1083

merged 4 commits into from
Oct 2, 2022
+42 −102

Conversation

ISSOtm
Copy link
Member

@ISSOtm ISSOtm commented Oct 1, 2022

  • Remove platforms deprecated by GitHub Actions
  • Add new platforms supported by the same

Fixes #785

@ISSOtm
Copy link
Member Author

ISSOtm commented Oct 1, 2022 •
edited
Loading

To fix:

  • 32-bit cross-build yields bad executables, and I'm not sure why.
  • Is libstdc++-6.dll required by the new 32-bit build ?

Sorry, something went wrong.

@Rangi42 Rangi42 added this to the 0.6.0 milestone Oct 1, 2022
@Rangi42 Rangi42 added tests This affects the test suite meta This isn't related to the tools directly: repo organization, maintainership... labels Oct 1, 2022
@Rangi42 Rangi42 removed this from the 0.6.0 milestone Oct 1, 2022
@ISSOtm ISSOtm force-pushed the update-ci branch 5 times, most recently from 23b047a to 4ff236e Compare October 1, 2022 22:59
@ISSOtm ISSOtm requested a review from Rangi42 October 1, 2022 23:00
ISSOtm added 4 commits October 2, 2022 01:03
@ISSOtm
Update CI target OSes
ed23f6c 
Remove platforms deprecated by GitHub Actions
Add new platforms supported by the same
@ISSOtm
Fix use of bitwise OR instead of logical
d2aa8df 
Thanks, Clang!
@ISSOtm
Properly build and link against libpng
766c223 
Doing it right this time.
Also bundling the newly required DLLs.
@ISSOtm
Properly exclude GCC from macOS matrices
d26b216
Rangi42
Rangi42 requested changes Oct 2, 2022
View reviewed changes
Copy link
Contributor

@Rangi42 Rangi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rgbds-canary-mingw-win32 works, but rgbds-canary-mingw-win64 is missing libstd++-6.dll.

The win32 zip includes libgcc_s_dw2-1.dll, libssp-0.dll, and libstdc++-6.dll, which the win64 zip does not.

Running rgbds-canary-mingw-win64's .\rgbgfx:

image

@Rangi42 Rangi42 added this to the 0.6.0 milestone Oct 2, 2022
@Rangi42
Copy link
Contributor

Rangi42 commented Oct 2, 2022

Tried again after re-running CI and they both work now. Maybe I downloaded the wrong zip, or an outdated one, at first.

@Rangi42 Rangi42 merged commit ab12c47 into gbdev:master Oct 2, 2022
@ISSOtm ISSOtm deleted the update-ci branch November 5, 2023 10:12
@Rangi42 Rangi42 mentioned this pull request Nov 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rangi42 Rangi42

Assignees
No one assigned
Labels
meta This isn't related to the tools directly: repo organization, maintainership... tests This affects the test suite
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Enable CI to build windows-xtesting with ubuntu-latest
2 participants
@ISSOtm @Rangi42