Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only warn about unmapped characters in non-empty charmaps #1061

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Only warn about unmapped characters in non-empty charmaps #1061

merged 2 commits into from
Sep 29, 2022
+49 −19

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Sep 26, 2022

Fixes #1058

@Rangi42 Rangi42 added bug Unexpected behavior / crashes; to be fixed ASAP! rgbasm This affects RGBASM labels Sep 26, 2022
@Rangi42 Rangi42 added this to the 0.6.0 milestone Sep 26, 2022
@Rangi42 Rangi42 requested a review from ISSOtm September 26, 2022 22:12
@Rangi42
Copy link
Contributor Author

Rangi42 commented Sep 29, 2022

@vulcandth Did you see the comment on #1058? This needs updating.

@vulcandth
Copy link

@vulcandth Did you see the comment on #1058? This needs updating.

Sorry I actually missed ISSOtm's comment somehow.

@Rangi42
Copy link
Contributor Author

Rangi42 commented Sep 29, 2022

@ISSOtm This now supports -Wunmapped-char=0/1/2.

@Rangi42 Rangi42 merged commit c35cb6a into gbdev:master Sep 29, 2022
@Rangi42 Rangi42 deleted the wunmapped-char branch September 29, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vulcandth vulcandth

@ISSOtm ISSOtm

Assignees
No one assigned
Labels
bug Unexpected behavior / crashes; to be fixed ASAP! rgbasm This affects RGBASM
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Don't print -Wunmapped-char for any empty charmap
3 participants
@Rangi42 @vulcandth @ISSOtm