Skip to content

Add -I as an alias for -i in rgbasm #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2022
Merged

Add -I as an alias for -i in rgbasm #1056

merged 2 commits into from
Sep 26, 2022

Conversation

ISSOtm
Copy link
Member

@ISSOtm ISSOtm commented Sep 25, 2022

Fixes #1045

@ISSOtm ISSOtm requested a review from Rangi42 September 25, 2022 14:40
Rangi42
Rangi42 previously requested changes Sep 25, 2022
View reviewed changes
Copy link
Contributor

@Rangi42 Rangi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If -i is going to still be supported, it should at least be documented in a source comment, if not in the public docs.

@Rangi42
Copy link
Contributor

Rangi42 commented Sep 25, 2022

Release notes if this does merge, with the other deprecated items:

  • rgbasm -i is not deprecated, but rgbasm -I is now preferred, to match gcc and clang.

@Rangi42 Rangi42 self-requested a review September 26, 2022 07:31
@Rangi42 Rangi42 dismissed their stale review September 26, 2022 07:32

Added comment

@Rangi42 Rangi42 merged commit 6502ed3 into gbdev:master Sep 26, 2022
@ISSOtm ISSOtm deleted the Include branch November 5, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rangi42 Rangi42 Rangi42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add -I as an alias for -i in rgbasm
2 participants
@ISSOtm @Rangi42