Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the STAT register PPU mode when the PPU is disabled #583

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

alloncm
Copy link
Contributor

@alloncm alloncm commented Jan 19, 2025

I verified this on SameBoy with some manual tests.

Let me know if you think this requires a proper test rom.

Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this! This is indeed a good remark, as I see it tripping people up. I believe at least one test ROM matches this, though @LIJI32 would have a better idea than I of which one.

Co-authored-by: Eldred Habert <[email protected]>
@avivace avivace merged commit ede0325 into gbdev:master Feb 26, 2025
2 of 3 checks passed
@avivace
Copy link
Member

avivace commented Feb 26, 2025

thanks a lot @alloncm !

@alloncm alloncm deleted the disabled_ppu_mode branch February 26, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants