Add warning suppression macro for unused static functions - #226
Open
luca-della-vedova wants to merge 2 commits into
Open
Add warning suppression macro for unused static functions#226luca-della-vedova wants to merge 2 commits into
luca-della-vedova wants to merge 2 commits into
Conversation
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Similar to #217, add warning suppression for unused static functions.
Context in gazebosim/gz-common#874, where we are trying to use a header-only library compiled with internal linkage (hence all functions are set as static). Unless we use every single function the compiler will complain that some of the libraries APIs are not used, which is clearly a spurious warning.
Backport Policy
This is really only needed from Jetty onwards (as per upstream PR), but it doesn't hurt.
Test it
Testing in CI, first commit adds the test without the warning suppression macro and should fail, second commit will add the macro and should make CI green again.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.