Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative install path for gz tool data #492

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 4, 2024

🦟 Bug fix

Summary

Fixes an error when building https://github.com/gazebo-release/gz_transport_vendor/ in the ROS buildfarm.

Similar to gazebosim/gz-tools#137

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from caguero as a code owner April 4, 2024 18:15
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.73%. Comparing base (eac2e69) to head (ddc0444).
Report is 11 commits behind head on gz-transport13.

Additional details and impacted files
@@                Coverage Diff                 @@
##           gz-transport13     #492      +/-   ##
==================================================
+ Coverage           87.69%   87.73%   +0.04%     
==================================================
  Files                  59       59              
  Lines                5704     5708       +4     
==================================================
+ Hits                 5002     5008       +6     
+ Misses                702      700       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey
Copy link
Contributor Author

azeey commented Apr 5, 2024

The homebrew failure is due to a recent change in protobuf and not related to this PR. I'll go ahead and merge.

@azeey azeey merged commit e9c63b1 into gz-transport13 Apr 5, 2024
9 of 11 checks passed
@azeey azeey deleted the azeey/rel_paths branch April 5, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants