Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::shared_ptr for gz::transport::NodeShared #484

Merged
merged 8 commits into from
Mar 21, 2024
Merged

Use std::shared_ptr for gz::transport::NodeShared #484

merged 8 commits into from
Mar 21, 2024

Commits on Mar 15, 2024

  1. Fix test failures when run under colcon test 

    Signed-off-by: Addisu Z. Taddese <[email protected]>
    @azeey
    azeey committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    3bb6be3 View commit details
    Browse the repository at this point in the history

  2. Use a std::shared_ptr for NodeShared 

    Currently, `NodeShared` is never destroyed once it's created. This makes
it hard for writing tests that do not interfere with each other. This
patch uses a reference counted smart pointer (`std::shared_ptr`) to keep
track of `NodeShared` instances, so that it gets properly destroyed when
when all `Node` instances, which themselves contain `NodeShared`
instances are destroyed.

Signed-off-by: Addisu Z. Taddese <[email protected]>
    @azeey
    azeey committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    4d836cd View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. Keep signature of Node::Shared to maintain ABI stability 

    `Node::Shared` is a private function but it's used in `details/Node.hh`
in templates which means there could be calls to `Node::Shared` embedded
in other libraries. Since we're mainly tracking the number of `Node`
instances, and since `Node::Shared` is private, it's okay to use raw pointers
internal use.

Signed-off-by: Addisu Z. Taddese <[email protected]>
    @azeey
    azeey committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    5bcb60f View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Fix ABI failure and linter 

    Signed-off-by: Addisu Z. Taddese <[email protected]>
    @azeey
    azeey committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    b36e874 View commit details
    Browse the repository at this point in the history

  2. Fix race condition 

    Signed-off-by: Addisu Z. Taddese <[email protected]>
    @azeey
    azeey committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    60cdec5 View commit details
    Browse the repository at this point in the history

  3. Fix windows 

    Signed-off-by: Addisu Z. Taddese <[email protected]>
    @azeey
    azeey committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    10d6087 View commit details
    Browse the repository at this point in the history

  4. Exclude deprecated function from code coverage test 

    Signed-off-by: Addisu Z. Taddese <[email protected]>
    @azeey
    azeey committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    35d1c83 View commit details
    Browse the repository at this point in the history

  5. Use a std::mutex since std::weak_ptr::lock is atomic 

    Signed-off-by: Addisu Z. Taddese <[email protected]>
    @azeey
    azeey committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    1f2d6f4 View commit details
    Browse the repository at this point in the history