Cherry-pick #472 to main: Find Python3 directly, not with GzPython #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the use of gz-cmake's GzPython in favor of a single call to find_package(Python3). This allows setting Python3_EXECUTABLE to specify which python version to use and is needed on macOS. Signed-off-by: Steve Peters <[email protected]>
azeey
approved these changes
Feb 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
+ Coverage 87.78% 87.82% +0.03%
==========================================
Files 59 59
Lines 5699 5699
==========================================
+ Hits 5003 5005 +2
+ Misses 696 694 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #472 is a fix that will unbreak several CI jobs on macOS. It will be merged forward to main in #479, but that is slowed down by issues with commented tests, so I am cherry-picking this so expedite the fix of CI.
Commit message:
Note to maintainers: Remember to use Rebase-and-Merge.