Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the third level commands for the log #451

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

Voldivh
Copy link
Contributor

@Voldivh Voldivh commented Oct 5, 2023

🎉 New feature

This PR addresses the issue gazebosim/gz-tools#1 regarding adding the third-level flags for log command.

Summary

Test it

$ . install/share/bash-completion/completions/ign
$ ign log r<tab> 

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #451 (8bf5016) into ign-transport8 (b3a8182) will increase coverage by 4.19%.
The diff coverage is 80.28%.

❗ Current head 8bf5016 differs from pull request most recent head 3134c5f. Consider uploading reports for the commit 3134c5f to get more accurate results

@@                Coverage Diff                 @@
##           ign-transport8     #451      +/-   ##
==================================================
+ Coverage           83.56%   87.76%   +4.19%     
==================================================
  Files                  51       59       +8     
  Lines                5039     5696     +657     
==================================================
+ Hits                 4211     4999     +788     
+ Misses                828      697     -131     
Files Coverage Δ
include/gz/transport/AdvertiseOptions.hh 100.00% <ø> (ø)
include/gz/transport/Clock.hh 100.00% <ø> (ø)
include/gz/transport/HandlerStorage.hh 100.00% <100.00%> (ø)
include/gz/transport/Publisher.hh 100.00% <ø> (ø)
include/gz/transport/RepHandler.hh 86.04% <ø> (+0.68%) ⬆️
include/gz/transport/ReqHandler.hh 81.65% <ø> (+1.06%) ⬆️
include/gz/transport/SubscriptionHandler.hh 85.45% <ø> (+0.54%) ⬆️
include/gz/transport/TopicStatistics.hh 100.00% <ø> (ø)
include/gz/transport/TopicStorage.hh 100.00% <100.00%> (ø)
include/gz/transport/Uuid.hh 100.00% <ø> (ø)
... and 36 more

... and 7 files with indirect coverage changes

@Voldivh Voldivh marked this pull request as ready for review October 5, 2023 19:33
@Voldivh Voldivh requested a review from caguero as a code owner October 5, 2023 19:33
@Voldivh Voldivh requested a review from azeey October 5, 2023 19:33
@Voldivh Voldivh changed the base branch from gz-transport13 to ign-transport8 October 12, 2023 14:25
@azeey
Copy link
Contributor

azeey commented Oct 16, 2023

@j-rivero ign_transport-ci-pr_any-bionic-amd64 job is saying /bin/bash: ./scripts/jenkins-scripts/docker/ign_transport-compilation.bash: No such file or directory. Is this a recent change?

@j-rivero
Copy link
Contributor

@j-rivero ign_transport-ci-pr_any-bionic-amd64 job is saying /bin/bash: ./scripts/jenkins-scripts/docker/ign_transport-compilation.bash: No such file or directory. Is this a recent change?

ugh, this is a bug introduced probably during the move the yaml file. Should be fixed by gazebo-tooling/release-tools#1043.

@j-rivero
Copy link
Contributor

@osrf-jenkins run tests

@Voldivh
Copy link
Contributor Author

Voldivh commented Oct 31, 2023

Friendly ping @azeey

@azeey
Copy link
Contributor

azeey commented Oct 31, 2023

Works for me. I'll go ahead and merge.

@azeey azeey merged commit ce66a7c into ign-transport8 Oct 31, 2023
12 checks passed
@azeey azeey deleted the voldivh/log_bash_completion branch October 31, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants