Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in bash completion, add help completion #86

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

mabelzhang
Copy link
Contributor

🦟 Bug fix

2 fixes before further changes to the file while working on #1. Original code #77.

  • COMPWORDS is a typo
  • ign help was not in tab completion. Now you can type ign <tab> and get help as a possible completion.

Summary

Test with this:

. etc/ign.bash_completion.sh

# `help` should be listed as an available command after the PR
ign <tab>

# `help` should be auto completed
ign h<tab>

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@osrf-triage osrf-triage added this to Inbox in Core development Apr 25, 2022
@github-actions github-actions bot added 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Apr 25, 2022
Core development automation moved this from Inbox to In review Apr 26, 2022
@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label Apr 27, 2022
@chapulina chapulina merged commit 20bcaf9 into ign-tools1 Apr 27, 2022
@chapulina chapulina deleted the mabelzhang/fix_bash_completion branch April 27, 2022 00:22
Core development automation moved this from In review to Done Apr 27, 2022
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress OOBE 📦✨ Out-of-box experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants