Add colcon.pkg with gz-cmake4 dependency #142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes
colcon
build ordering since #136 was mergedSummary
Since #128,
gz-tools2
supports building with eithergz-cmake3
orgz-cmake4
, andcolcon
was correctly identifying the dependency relationship due to the cmakefind_package
calls. Apackage.xml
was added in #136 with abuild_depend
only ongz-cmake3
, which now breaks the build-from-source order for Ionic workspaces that includegz-tools2
:This pull request adds a
colcon.pkg
file with an explicit dependency ongz-cmake4
to fix the build orderAlternatives considered
colcon.pkg
to force the build type back tocmake
: f18e584. This also fixes the build (), but it has more side-effects that just addinggz-cmake4
as a dependency.<member_of_group>gz-cmake</member_of_group>
to thepackage.xml
file ingz-cmake3
andgz-cmake4
and a<group_depend>gz-cmake</group_depend>
tag in downstream package.xml files (thanks to @cottsay for the suggestion). This is more elegant but requires more coordination between packages, while thiscolcon.pkg
change can fix CI now.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.