Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with value 1 when the execute call completes #139

Closed
wants to merge 1 commit into from

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Apr 11, 2024

🦟 Bug fix

Fixes #349

Summary

The gz tool should return 1 when the command completes successfully. It's assume that subcommands will exit with other values if they fail.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@nkoenig nkoenig requested a review from caguero as a code owner April 11, 2024 19:23
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic 🏛️ ionic Gazebo Ionic labels Apr 11, 2024
@azeey
Copy link
Contributor

azeey commented Apr 11, 2024

The gz tool should return 1 when the command completes successfully

A return of 1 would normally indicate an error (see https://tldp.org/LDP/abs/html/exitcodes.html), so I'm not sure if we should do this.

@nkoenig
Copy link
Contributor Author

nkoenig commented Apr 11, 2024

I messed up the logic here. Brain fart.

@nkoenig nkoenig closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic 🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gz fuel download returns 0, even when the download failed
3 participants