Add project soversion information to backward library #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library being installed doesn't have a SOVERSION like other libraries created in Gazebo projects, and is flagged as a packaging error by rpmlint. Signed-off-by: Scott K Logan <[email protected]>
github-actions
bot
added
🌱 garden
mjcarroll
approved these changes
Jan 29, 2024
j-rivero
approved these changes
Feb 1, 2024
scpeters
added a commit
to gazebo-release/gz-tools2-release
that referenced
this pull request
Feb 7, 2024
Follow-up to gazebosim/gz-tools#133. Signed-off-by: Steve Peters <[email protected]>
This was referenced Feb 7, 2024
|
I've updated the debian metadata in gazebo-release/gz-tools2-release#15 in response to this change (see also gazebosim/gz-transport#479 (comment)) |
scpeters
added a commit
to gazebo-release/gz-tools2-release
that referenced
this pull request
Feb 8, 2024
Follow-up to gazebosim/gz-tools#133. Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The library being installed doesn't have a SOVERSION like other libraries created in Gazebo projects, and is flagged as a packaging error by rpmlint.
This will result in a change to the library's filename on Linux, which will now become
libgz-tools2-backward.so.2.0.0. This is handled correctly by the use of$<TARGET_FILE_NAME:backward>for referencing the library in thegzexecutable.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.