Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source bash completion files for all other gz libraries #104

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 10, 2022

🎉 New feature

Toward #1
Replaces #103 (Creating a new PR with a branch on the upstream repo instead of a fork so I can test with a debbuilder job).

Summary

Source the gz*.completion file from wherever its installed so that the bash completion functions for other gz libraries can be picked up automatically.

Additionally, this installed the cmake configured etc/ign.bash_completion.sh file to <prefix>/share/bash-completion/completions/ign instead of relying on the debian/homebrew build infrastructure (see gazebo-release/gz-tools-release#6). This has two advantages (1) makes it easy to use the cmake configured file so we can have cmake variables in etc/ign.bash_completion.sh (2) tab completion works the same way when building from source if <prefix> is set to /usr.

Related:
gazebo-release/gz-tools-release#6

Test it

To build this with gazebo-release/gz-tools-release#6 on focal, symlink gz-tools-release/focal/debian into the the root directory of gz-tools, then from the root directory of gz-tools, build the deb files using dpkg-buildpackage -us -uc -b. The deb files will be created in the parent directory. You can then copy the debs to a docker container, install it, and test tab completion.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from mjcarroll August 10, 2022 18:48
@azeey azeey requested a review from caguero as a code owner August 10, 2022 18:48
@github-actions github-actions bot added 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Aug 10, 2022
@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label Aug 10, 2022
@azeey azeey merged commit 62c11f4 into ign-tools1 Aug 11, 2022
@azeey azeey deleted the azeey/source_other_compl branch August 11, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants