Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative install paths for plugin shared libraries and media files #984

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 4, 2024

🦟 Bug fix

Summary

Fixes an error when building https://github.com/gazebo-release/gz_rendering_vendor/ in the ROS buildfarm.

Similar to gazebosim/gz-tools#137

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from iche033 as a code owner April 4, 2024 18:09
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.68%. Comparing base (e187f52) to head (f2ecc4f).

❗ Current head f2ecc4f differs from pull request most recent head f13205e. Consider uploading reports for the commit f13205e to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           gz-rendering8     #984   +/-   ##
==============================================
  Coverage          75.68%   75.68%           
==============================================
  Files                177      177           
  Lines              16959    16959           
==============================================
  Hits               12835    12835           
  Misses              4124     4124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…_RESOURCE_PATH`

Instead use `GZ_RENDERING_ENGINE_RELATIVE_INSTALL_DIR` and `GZ_RENDERING_RELATIVE_RESOURCE_PATH`

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey
Copy link
Contributor Author

azeey commented Apr 10, 2024

Based on gazebosim/gz-physics#616 (comment), I've reverted changes to GZ_RENDERING_ENGINE_INSTALL_DIR and GZ_RENDERING_RESOURCE_PATH and instead used GZ_RENDERING_ENGINE_RELATIVE_INSTALL_DIR and GZ_RENDERING_RELATIVE_RESOURCE_PATH in f13205e

One way I've found to test this is to go into the build directory and run

cmake -DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON -P cmake_install.cmake

(Make sure to have the latest version of gz-cmake3)

@caguero
Copy link
Contributor

caguero commented Apr 10, 2024

Just checking, are the Windows CI issues expected?

@azeey
Copy link
Contributor Author

azeey commented Apr 10, 2024

Just checking, are the Windows CI issues expected?

I believe so. Here's the build for the gz-rendering8 branch: https://build.osrfoundation.org/job/gz_rendering-8-win/38/testReport/

@azeey azeey merged commit 2e9fa26 into gz-rendering8 Apr 10, 2024
7 of 8 checks passed
@azeey azeey deleted the azeey/rel_paths branch April 10, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants