Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bionic from future releases (Garden+) #583

Merged
merged 4 commits into from
Mar 15, 2022

Conversation

chapulina
Copy link
Contributor

Summary

ign-rendering7 will be on Garden.

Test it

No Bionic builds should be triggered. I hope the camera test passes on Focal.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added documentation Improvements or additions to documentation tests Broken or missing tests / testing infra labels Mar 11, 2022
@chapulina chapulina requested a review from iche033 as a code owner March 11, 2022 19:46
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 11, 2022
Signed-off-by: Louise Poubel <[email protected]>
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #583 (71e5a57) into main (2908969) will increase coverage by 0.35%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
+ Coverage   53.08%   53.43%   +0.35%     
==========================================
  Files         214      214              
  Lines       21299    21301       +2     
==========================================
+ Hits        11306    11383      +77     
+ Misses       9993     9918      -75     
Impacted Files Coverage Δ
include/ignition/rendering/HeightmapDescriptor.hh 100.00% <ø> (ø)
include/ignition/rendering/Mesh.hh 100.00% <ø> (ø)
ogre2/src/Ogre2Heightmap.cc 0.00% <0.00%> (ø)
ogre/src/OgreHeightmap.cc 72.70% <100.00%> (ø)
...lude/ignition/rendering/base/BaseDistortionPass.hh 0.00% <0.00%> (ø)
ogre2/src/Ogre2RenderEngine.cc 78.72% <0.00%> (+0.21%) ⬆️
ogre/src/OgreRenderEngine.cc 73.65% <0.00%> (+0.29%) ⬆️
ogre2/src/Ogre2Mesh.cc 83.80% <0.00%> (+0.70%) ⬆️
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 100.00% <0.00%> (+3.33%) ⬆️
ogre2/src/Ogre2MaterialSwitcher.cc 79.41% <0.00%> (+6.86%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cc48ac...71e5a57. Read the comment docs.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

This is good to go!

@chapulina chapulina mentioned this pull request Mar 15, 2022
7 tasks
@chapulina chapulina merged commit 23955a9 into main Mar 15, 2022
@chapulina chapulina deleted the chapulina/main/rm/bionic branch March 15, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🌱 garden Ignition Garden tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants