Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require geospatial component #539

Merged
merged 6 commits into from
Mar 15, 2022
Merged

Require geospatial component #539

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e63605e
require geospatial component
iche033 Jan 19, 2022
67c7079
add gdal dep
iche033 Jan 19, 2022
effaefd
revert dep
iche033 Jan 19, 2022
ce615f8
Update header locations
scpeters Jan 19, 2022
ffacdc5
Update heightmap size & added DEM example (#560)
jennuine Mar 15, 2022
0975461
merged from main
chapulina Mar 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ set(IGN_MATH_VER ${ignition-math7_VERSION_MAJOR})
#--------------------------------------
# Find ignition-common
ign_find_package(ignition-common5 REQUIRED
COMPONENTS graphics events)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The geospatial component in ign-common is optional, while geospatial is required here. Is that intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm if we make the geospatial component optional here, we will need to make heightmaps in ign-rendering optional as well and only build it if the geospatial component is available. We'll likely need to do the same in ign-gazebo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we revert the ign-common PR for now while we sort this out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok that sounds good as this will require a bigger change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gazebosim/gz-common#291

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a previous f2f meeting with @chapulina , we decided against making GDAL an optional component because it was going to add a layer of difficulty managing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I remember also discussing this at the weekly meeting. GDAL will be required for heightmaps. Ignition Physics already has a separate heightmap component, so only that component needs to depend on geopspatial. But Ignition Rendering doesn't have that separation and with the current architecture I think it may be difficult to break that apart.

COMPONENTS graphics events geospatial)
set(IGN_COMMON_VER ${ignition-common5_VERSION_MAJOR})

#--------------------------------------
Expand Down
4 changes: 2 additions & 2 deletions examples/heightmap/Main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
#include <vector>

#include <ignition/common/Console.hh>
#include <ignition/common/HeightmapData.hh>
#include <ignition/common/ImageHeightmap.hh>
#include <ignition/common/geospatial/HeightmapData.hh>
#include <ignition/common/geospatial/ImageHeightmap.hh>
#include <ignition/rendering.hh>

#include "example_config.hh"
Expand Down
2 changes: 1 addition & 1 deletion include/ignition/rendering/HeightmapDescriptor.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

#include <memory>
#include <string>
#include <ignition/common/HeightmapData.hh>
#include <ignition/common/geospatial/HeightmapData.hh>
#include <ignition/common/SuppressWarning.hh>

#include "ignition/rendering/config.hh"
Expand Down
2 changes: 1 addition & 1 deletion src/Heightmap_TEST.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#include <gtest/gtest.h>

#include <ignition/common/Console.hh>
#include <ignition/common/ImageHeightmap.hh>
#include <ignition/common/geospatial/ImageHeightmap.hh>
#include <ignition/utilities/ExtraTestMacros.hh>

#include "test_config.h" // NOLINT(build/include)
Expand Down