Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to implement EntityManagementFeatures #548

Open
2 tasks
scpeters opened this issue Sep 21, 2023 · 0 comments
Open
2 tasks

Make it easier to implement EntityManagementFeatures #548

scpeters opened this issue Sep 21, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@scpeters
Copy link
Member

Desired behavior

It takes a lot of code in the Base.* and EntityManagementFeatures.* files in our plugin implementations to implement the GetEntities features. It would be nice to simplify this and reduce the amount of duplicate code required for each plugin implementation.

Alternatives considered

Implementation suggestion

  • Share the definition of EntityStorage from dartsim's Base.hh with other plugins
  • Identify code that can be generalized and move it to a shared library if possible (hopefully not more templates) to reduce the number of methods needed to implement a plugin

Additional context
@scpeters scpeters added the enhancement New feature or request label Sep 21, 2023
@azeey azeey moved this from Inbox to To do in Core development Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Core development
Status: To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scpeters