Line2: increase test coverage (backport #807) - #829
Merged
Conversation
Contributor
Author
|
Cherry-pick of 268039c has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
mergify
Bot
requested review from
adityapande-1995 and
scpeters
as code owners
August 25, 2026 08:42
19 tasks
caguero
force-pushed
the
mergify/bp/ign-math6/pr-807
branch
from
August 25, 2026 19:12
998ecac to
bfae060
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ign-math6 #829 +/- ##
=============================================
- Coverage 99.38% 97.85% -1.54%
=============================================
Files 75 75
Lines 7029 7582 +553
=============================================
+ Hits 6986 7419 +433
- Misses 43 163 +120 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Assisted-by: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Carlos Agüero <caguero@honurobotics.com>
caguero
force-pushed
the
mergify/bp/ign-math6/pr-807
branch
from
August 25, 2026 19:42
bfae060 to
28a6008
Compare
caguero
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Improve test coverage of Line2 class
Summary
This increases test coverage based on suggestions from Gemini. After observing some windows C4244 compiler warnings, I fixed them in 2a719e4:
Set(double, double, double, double)by wrapping withstatic_cast<T>Length()by using the simpler implementation fromLine3.hhwrapped withstatic_cast<T>:gz-math/include/gz/math/Line3.hh
Lines 135 to 138 in 396f5a5
Summary of test coverage improvements
Backport Policy
Checklist
codecheckpassed (See contributing)Assisted-by: Gemini 3.6 Flash
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.
This is an automatic backport of pull request #807 done by [Mergify](https://mergify.com).