Filter: increase test coverage - #816
Open
scpeters wants to merge 2 commits into
Open
Conversation
1. Set & Value Methods: added test coverage in OnePoleQuaternion, OnePoleVector3, and BiQuadVector3. 2. Fc: added test calls for Fc overloads in BiQuadVector3. 3. Multi-Step Process State Updates: call Process multiple times to exercise internal recursive feedback state updates. 4. Template Types: test float and int instantiations: OnePole<float>, OnePole<int>, BiQuad<float>, BiQuad<int>. Also use static_cast<T> to fix type conversion warnings. Assisted-by: Gemini 3.6 Flash Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Improve test coverage of the
Filterclasses, similar to #807Summary
This increases test coverage based on suggestions from Gemini and uses
static_cast<T>where needed to fix windows C4244 compiler warnings.Summary of test coverage improvements
OnePole<float>,OnePole<int>,BiQuad<float>,BiQuad<int>.Backport Policy
Checklist
codecheckpassed (See contributing)Assisted-by: Gemini 3.6 Flash
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.