Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package.xml #581

Merged
merged 7 commits into from
Apr 19, 2024
Merged

Add package.xml #581

merged 7 commits into from
Apr 19, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Feb 23, 2024

🎉 New feature

Summary

Add package.xml based on dependencies found in .github/ci/packages.

This is to test out using vendor packages to provide Gazebo packages to ROS users (see gazebo-tooling/release-tools#1117).

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.11%. Comparing base (f0d4e59) to head (ac2bf04).

❗ Current head ac2bf04 differs from pull request most recent head 3054479. Consider uploading reports for the commit 3054479 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           gz-math7     #581      +/-   ##
============================================
- Coverage     94.11%   94.11%   -0.01%     
============================================
  Files           146      146              
  Lines          9809     9804       -5     
============================================
- Hits           9232     9227       -5     
  Misses          577      577              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey
Copy link
Contributor Author

azeey commented Apr 17, 2024

@scpeters This is ready for review.

package.xml Outdated
<name>gz-math7</name>
<version>7.4.0</version>
<description>Gazebo Math : Math classes and functions for robot applications</description>
<maintainer email="[email protected]">Nate Koenig</maintainer>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityapande-1995 and I are listed as the CODEOWNERS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this from the README. Should we update that as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, let's update the README as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or remove it from the README

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we list maintainers in the README of other packages

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so yes, let's update the readme as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 3054479

Signed-off-by: Addisu Z. Taddese <[email protected]>
@scpeters scpeters merged commit a76819b into gz-math7 Apr 19, 2024
12 checks passed
@scpeters scpeters deleted the package_xml branch April 19, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants