Remove HIDE_SYMBOLS_BY_DEFAULT: replace by a default configuration in gz-cmake. #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gz-cmake. See gazebosim/gz-cmake#166 (comment) Signed-off-by: Jose Luis Rivero <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 143 143
Lines 9940 9940
=======================================
Hits 9541 9541
Misses 399 399 ☔ View full report in Codecov by Sentry. |
scpeters
approved these changes
Jan 11, 2024
|
Umm the |
I udpated the required CI settings for this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See gazebosim/gz-cmake#166