Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODOs in main #541

Merged
merged 1 commit into from
Aug 1, 2023
Merged

TODOs in main #541

merged 1 commit into from
Aug 1, 2023

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 27, 2023

🎉 New feature

Summary

This PR builds on top of this other PR #540 and it resolves some of the TODOs

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #541 (86f75d6) into ahcorde/7_to_main/270723 (8a5bb56) will increase coverage by 0.18%.
The diff coverage is 100.00%.

❗ Current head 86f75d6 differs from pull request most recent head a8db2a1. Consider uploading reports for the commit a8db2a1 to get more accurate results

@@                     Coverage Diff                      @@
##           ahcorde/7_to_main/270723     #541      +/-   ##
============================================================
+ Coverage                     94.34%   94.53%   +0.18%     
============================================================
  Files                           144      144              
  Lines                          9660     9626      -34     
============================================================
- Hits                           9114     9100      -14     
+ Misses                          546      526      -20     
Files Changed Coverage Δ
include/gz/math/Helpers.hh 100.00% <ø> (ø)
src/python_pybind11/src/Helpers.cc 88.18% <100.00%> (+11.09%) ⬆️

@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
@azeey azeey requested a review from nkoenig July 31, 2023 18:27
@mjcarroll mjcarroll merged commit 11bdf53 into ahcorde/7_to_main/270723 Aug 1, 2023
9 checks passed
@mjcarroll mjcarroll deleted the ahcorde/main/todos branch August 1, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants