Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bionic from future releases (Garden+) #150

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

chapulina
Copy link
Contributor

Summary

ign-launch6 will be on Garden.

Test it

No Bionic builds should be triggered.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina requested a review from nkoenig as a code owner March 11, 2022 19:24
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #150 (0bcb3e6) into main (51cab20) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   32.92%   32.92%           
=======================================
  Files           4        4           
  Lines         817      817           
=======================================
  Hits          269      269           
  Misses        548      548           
Impacted Files Coverage Δ
src/vendor/backward.hpp 8.55% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51cab20...0bcb3e6. Read the comment docs.

@chapulina
Copy link
Contributor Author

I manually cancelled the Windows job because the buildfarm was swamped and this PR shouldn't affect that. I think this is good to merge!

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit f40d7a7 into main Mar 17, 2022
@chapulina chapulina deleted the chapulina/main/rm/bionic branch March 17, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants