Expose shadow texture size for directional lighting in SDF #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only recently realized that my PR breaks ABI, so PR is for EDIT - my changes in both gz-gui, gz-rendering work in |
Signed-off-by: Athena Z <[email protected]>
Signed-off-by: Athena Z <[email protected]>
Signed-off-by: Athena Z <[email protected]>
Signed-off-by: Athena Z <[email protected]>
Signed-off-by: Athena Z <[email protected]>
Signed-off-by: Athena Z <[email protected]>
Signed-off-by: Athena Z <[email protected]>
athenaz2
force-pushed
the
athenaz/texsize_in_sdf
branch
from
db34426
to
acea8e3
Compare
…false; update names of enum vals used Signed-off-by: Athena Z <[email protected]>
Signed-off-by: Athena Z <[email protected]>
|
@iche033 if you have some bandwidth, would you be able to review this since you already have some context with gazebosim/gz-rendering#1034? |
yep will do |
iche033
reviewed
Aug 16, 2024
| @@ -238,6 +239,8 @@ namespace gz::gui::plugins | |||
| /// \brief True if sky is enabled; | |||
| public: bool skyEnable = false; | |||
|
|
|||
| public: unsigned int directionalLightTextureSize = 2048u; | |||
There was a problem hiding this comment.
Oops. Added here 0bc87f8
| @@ -368,6 +371,12 @@ namespace gz::gui::plugins | |||
| /// \param[in] _sky True to enable the sky, false otherwise. | |||
| public: void SetSkyEnabled(const bool &_sky); | |||
|
|
|||
| /// @brief \brief Set the shadow texture size for the given light type. | |||
| /// @param _lightType Light type that creates the shadow | |||
| /// @param _textureSize Shadow texture size | |||
There was a problem hiding this comment.
nit: replace @ with \ for consistency
Co-authored-by: Ian Chen <[email protected]> Signed-off-by: Athena Z. <[email protected]>
Signed-off-by: Athena Z <[email protected]>
iche033
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Related to gazebosim/gz-rendering#1034, view that for details.
Summary
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.